Cannot find the submit button after "+2"
Hi Brad,
On the below code review I submitted, there are "+2" already, but I cannot find the submit button on the web page,
Do I need to apply for other permissions or groups?
https://gerrit.openbmc-project.xyz/#/c/openbmc/intel-ipmi-oem/+/17234/,
Thanks,
Yong
Quoted 13 lines · Yong Li
Hi Brad,
On the below code review I submitted, there are "+2" already, but I cannot find the submit button on the web page,
Do I need to apply for other permissions or groups?
Quoted 8 lines
https://gerrit.openbmc-project.xyz/#/c/openbmc/intel-ipmi-oem/+/17234/,
Thanks,
Yong
Hi Yong
Whether or not the patch author clicks submit or the maintainer clicks submit is a matter of maintainer preference. I prefer to oversee the merging of changes into the repositories I maintain. I know that other maintainers perfer to approve the change but delegate the actual submission to the patch author (and that is fine).
I'm working on assigning the owner permission to refs/* to the current repository maintainer for each openbmc repository. This would allow each repository maintainer to enable this (or not) as they see fit.
Thanks - brad
Thanks Brad! Will contact the maintainers to merge my changes
Thanks,
Yong
-----Original Message-----
From: openbmc <[email protected]> On Behalf Of Brad Bishop
Sent: Monday, May 20, 2019 9:32 PM
To: Yong Li <[email protected]>
Cc: 'OpenBMC Maillist' <[email protected]>; Li, Yong B <[email protected]>
Subject: Re: Cannot find the submit button after "+2"
Quoted 13 lines · Yong Li
Hi Brad,
On the below code review I submitted, there are "+2" already, but I cannot find the submit button on the web page,
Do I need to apply for other permissions or groups?
Quoted 8 lines
https://gerrit.openbmc-project.xyz/#/c/openbmc/intel-ipmi-oem/+/17234/,
Thanks,
Yong
Hi Yong
Whether or not the patch author clicks submit or the maintainer clicks submit is a matter of maintainer preference. I prefer to oversee the merging of changes into the repositories I maintain. I know that other maintainers perfer to approve the change but delegate the actual submission to the patch author (and that is fine).
I'm working on assigning the owner permission to refs/* to the current repository maintainer for each openbmc repository. This would allow each repository maintainer to enable this (or not) as they see fit.
Thanks - brad